Refactor jsonpath's compareDatetime()
authorAlexander Korotkov <akorotkov@postgresql.org>
Mon, 21 Oct 2019 20:04:14 +0000 (23:04 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Mon, 21 Oct 2019 20:07:07 +0000 (23:07 +0300)
commit52ad1e659967896ed153185328ffe806d69abcb6
tree03ab5a5db0c8bac802160dcf538a38a4025f92c9
parenta6888fde7f0dbe865559b31ba2ce01ac1150debe
Refactor jsonpath's compareDatetime()

This commit refactors come ridiculous coding in compareDatetime().  Also, it
provides correct cross-datatype comparison even when one of values overflows
during cast.  That eliminates dilemma on whether we should suppress overflow
errors during cast.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/32308.1569455803%40sss.pgh.pa.us
Discussion: https://postgr.es/m/a5629d0c-8162-7559-16aa-0c8390d6ba5f%40postgrespro.ru
Author: Nikita Glukhov, Alexander Korotkov
src/backend/utils/adt/date.c
src/backend/utils/adt/jsonpath_exec.c
src/backend/utils/adt/timestamp.c
src/include/utils/date.h
src/include/utils/timestamp.h
src/test/regress/expected/jsonb_jsonpath.out
src/test/regress/sql/jsonb_jsonpath.sql