Don't use custom OID symbols in pg_proc.dat.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 28 Oct 2020 16:18:45 +0000 (12:18 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 28 Oct 2020 16:18:45 +0000 (12:18 -0400)
commit36b93121436cbbf357974144068c23bac75154fa
treecb9fcd10a3e29459e1f6aa30f56f5941f029c932
parentad1c36b0709e47cdb3cc4abd6c939fe64279b63f
Don't use custom OID symbols in pg_proc.dat.

We have a perfectly good convention for OID macros for built-in functions
already, so making custom symbols is just introducing unnecessary
deviation from the convention.  Remove the one case that had snuck in,
and add an error check in genbki.pl to discourage future instances.

Although this touches pg_proc.dat, there's no need for a catversion
bump since the actual catalog data isn't changed.

John Naylor

Discussion: https://postgr.es/m/CAFBsxsHpCbjfoddNGpnnnY5pHwckWfiYkMYSF74PmP1su0+ZOw@mail.gmail.com
src/backend/catalog/genbki.pl
src/backend/utils/cache/relcache.c
src/include/catalog/pg_proc.dat