postgres_fdw: reestablish new connection if cached one is detected as broken.
authorFujii Masao <fujii@postgresql.org>
Tue, 6 Oct 2020 01:31:09 +0000 (10:31 +0900)
committerFujii Masao <fujii@postgresql.org>
Tue, 6 Oct 2020 01:51:07 +0000 (10:51 +0900)
commit32a9c0bdf493cf5fc029ab44a22384d547290eff
tree2d3984e535f8226c48122eacbe369150557e682b
parentdd0a64ed435d4a266ed16adb8204e7222af6c164
postgres_fdw: reestablish new connection if cached one is detected as broken.

In postgres_fdw, once remote connections are established, they are cached
and re-used for subsequent queries and transactions. There can be some
cases where those cached connections are unavaiable, for example,
by the restart of remote server. In these cases, previously an error was
reported and the query accessing to remote server failed if new remote
transaction failed to start because the cached connection was broken.

This commit improves postgres_fdw so that new connection is remade
if broken connection is detected when starting new remote transaction.
This is useful to avoid unnecessary failure of queries when connection is
broken but can be reestablished.

Author: Bharath Rupireddy, tweaked a bit by Fujii Masao
Reviewed-by: Ashutosh Bapat, Tatsuhito Kasahara, Fujii Masao
Discussion: https://postgr.es/m/CALj2ACUAi23vf1WiHNar_LksM9EDOWXcbHCo-fD4Mbr1d=78YQ@mail.gmail.com
contrib/postgres_fdw/connection.c
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/sql/postgres_fdw.sql