Improve new wording of libpq's connection failure messages.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 21 Jan 2021 21:10:18 +0000 (16:10 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 21 Jan 2021 21:10:18 +0000 (16:10 -0500)
commit27a48e5a16ff2227ddf44ee717d9bcd89d22a7aa
tree7b1861a7d0f35c213a1a8e0db54a13daeb07cd81
parent55dc86eca70b1dc18a79c141b3567efed910329d
Improve new wording of libpq's connection failure messages.

"connection to server so-and-so failed:" seems clearer than the
previous wording "could not connect to so-and-so:" (introduced by
52a10224e), because the latter suggests a network-level connection
failure.  We're now prefixing this string to all types of connection
failures, for instance authentication failures; so we need wording
that doesn't imply a low-level error.

Per discussion with Robert Haas.

Discussion: https://postgr.es/m/CA+TgmobssJ6rS22dspWnu-oDxXevGmhMD8VcRBjmj-b9UDqRjw@mail.gmail.com
src/bin/pg_dump/t/002_pg_dump.pl
src/interfaces/ecpg/test/expected/connect-test5.stderr
src/interfaces/ecpg/test/pg_regress_ecpg.c
src/interfaces/libpq/fe-connect.c