Revise GUC names quoting in messages again
authorPeter Eisentraut <peter@eisentraut.org>
Fri, 17 May 2024 09:23:08 +0000 (11:23 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 17 May 2024 09:44:26 +0000 (11:44 +0200)
commit17974ec259463869bb6bb4885d46847422fbc9ec
tree11cd393058415b42093277f2e15de7bf1e186579
parentbe5942aee7a012ce7f30bc7a6617903127f29e89
Revise GUC names quoting in messages again

After further review, we want to move in the direction of always
quoting GUC names in error messages, rather than the previous (PG16)
wildly mixed practice or the intermittent (mid-PG17) idea of doing
this depending on how possibly confusing the GUC name is.

This commit applies appropriate quotes to (almost?) all mentions of
GUC names in error messages.  It partially supersedes a243569bf65 and
8d9978a7176, which had moved things a bit in the opposite direction
but which then were abandoned in a partial state.

Author: Peter Smith <smithpb2250@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPv-kSN8SkxSdoHano_wPubqcg5789ejhCDZAcLFceBR-w%40mail.gmail.com
79 files changed:
contrib/pg_prewarm/autoprewarm.c
contrib/pg_stat_statements/pg_stat_statements.c
contrib/sepgsql/hooks.c
contrib/test_decoding/expected/slot.out
doc/src/sgml/sources.sgml
src/backend/access/gin/ginbulk.c
src/backend/access/heap/vacuumlazy.c
src/backend/access/table/tableamapi.c
src/backend/access/transam/commit_ts.c
src/backend/access/transam/multixact.c
src/backend/access/transam/rmgr.c
src/backend/access/transam/twophase.c
src/backend/access/transam/xlog.c
src/backend/access/transam/xlogarchive.c
src/backend/access/transam/xlogfuncs.c
src/backend/access/transam/xlogprefetcher.c
src/backend/access/transam/xlogrecovery.c
src/backend/commands/publicationcmds.c
src/backend/commands/vacuum.c
src/backend/commands/variable.c
src/backend/libpq/be-secure-openssl.c
src/backend/libpq/hba.c
src/backend/libpq/pqcomm.c
src/backend/parser/scan.l
src/backend/port/sysv_sema.c
src/backend/port/sysv_shmem.c
src/backend/port/win32_shmem.c
src/backend/postmaster/bgworker.c
src/backend/postmaster/checkpointer.c
src/backend/postmaster/pgarch.c
src/backend/postmaster/postmaster.c
src/backend/replication/logical/decode.c
src/backend/replication/logical/launcher.c
src/backend/replication/logical/logical.c
src/backend/replication/logical/origin.c
src/backend/replication/slot.c
src/backend/replication/syncrep.c
src/backend/storage/buffer/localbuf.c
src/backend/storage/file/fd.c
src/backend/storage/lmgr/lock.c
src/backend/storage/lmgr/predicate.c
src/backend/storage/lmgr/proc.c
src/backend/tcop/postgres.c
src/backend/utils/adt/pg_locale.c
src/backend/utils/adt/varlena.c
src/backend/utils/fmgr/dfmgr.c
src/backend/utils/misc/guc.c
src/backend/utils/misc/guc_tables.c
src/bin/initdb/initdb.c
src/bin/pg_basebackup/streamutil.c
src/bin/pg_controldata/pg_controldata.c
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_rewind/libpq_source.c
src/bin/pg_rewind/pg_rewind.c
src/bin/pg_test_fsync/pg_test_fsync.c
src/bin/pg_upgrade/check.c
src/bin/pg_upgrade/t/003_logical_slots.pl
src/bin/pg_upgrade/t/004_subscription.pl
src/bin/pgbench/pgbench.c
src/fe_utils/archive.c
src/interfaces/libpq/fe-auth.c
src/interfaces/libpq/fe-connect.c
src/test/modules/commit_ts/expected/commit_timestamp_1.out
src/test/modules/libpq_pipeline/libpq_pipeline.c
src/test/modules/ssl_passphrase_callback/ssl_passphrase_func.c
src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl
src/test/modules/test_shm_mq/setup.c
src/test/modules/test_slru/test_slru.c
src/test/recovery/t/024_archive_recovery.pl
src/test/recovery/t/035_standby_logical_decoding.pl
src/test/regress/expected/collate.icu.utf8.out
src/test/regress/expected/create_am.out
src/test/regress/expected/json.out
src/test/regress/expected/jsonb.out
src/test/regress/expected/prepared_xacts_1.out
src/test/regress/expected/strings.out
src/test/ssl/t/001_ssltests.pl
src/test/subscription/t/001_rep_changes.pl