pgcommitfest2.git
5 years agoSync up community auth plugin to latest-and-greatest
Magnus Hagander [Wed, 26 Feb 2020 17:21:52 +0000 (18:21 +0100)]
Sync up community auth plugin to latest-and-greatest

6 years agoRemove reundant role attribute
Daniel Gustafsson [Wed, 27 Mar 2019 14:56:48 +0000 (15:56 +0100)]
Remove reundant role attribute

6 years agoDon't include "target version" on new patch form
Magnus Hagander [Thu, 28 Feb 2019 11:24:23 +0000 (12:24 +0100)]
Don't include "target version" on new patch form

6 years agoRemove trailing slashes from message-id URLs
Peter Eisentraut [Wed, 27 Feb 2019 09:36:32 +0000 (10:36 +0100)]
Remove trailing slashes from message-id URLs

This avoids useless redirects.

6 years agoChange backgroud color of target version label
Magnus Hagander [Sun, 10 Feb 2019 19:29:55 +0000 (20:29 +0100)]
Change backgroud color of target version label

Per request

6 years agoAnother markup fix
Daniel Gustafsson [Wed, 6 Feb 2019 20:47:14 +0000 (21:47 +0100)]
Another markup fix

6 years agoFix markup
Daniel Gustafsson [Wed, 6 Feb 2019 20:45:36 +0000 (21:45 +0100)]
Fix markup

6 years agoAdd index to patchhistory.date
Magnus Hagander [Wed, 6 Feb 2019 20:36:42 +0000 (21:36 +0100)]
Add index to patchhistory.date

6 years agoFix activity feed queries
Magnus Hagander [Wed, 6 Feb 2019 20:36:01 +0000 (21:36 +0100)]
Fix activity feed queries

These clearly had little to do with reality since they would return
duplicate entries if a patch was in more than one cf..

6 years agoAdd a field to each patch for target version
Magnus Hagander [Wed, 6 Feb 2019 20:05:06 +0000 (21:05 +0100)]
Add a field to each patch for target version

This is particularly interesting towards the end of a cycle where it can
be used to flag patches that are not intended for the current version
but still needs review.

6 years agoAdd a pre-commit hook to ensure pep8
Magnus Hagander [Wed, 6 Feb 2019 19:41:59 +0000 (20:41 +0100)]
Add a pre-commit hook to ensure pep8

6 years agoFix mail sender for py3
Magnus Hagander [Wed, 6 Feb 2019 19:25:40 +0000 (20:25 +0100)]
Fix mail sender for py3

6 years agoUpdate migrations for py3 unicode
Magnus Hagander [Wed, 6 Feb 2019 19:19:54 +0000 (20:19 +0100)]
Update migrations for py3 unicode

Need to change old migrations not to indicate we need new ones.

6 years agoUpdate cmd tools to use python3
Magnus Hagander [Wed, 6 Feb 2019 19:09:15 +0000 (20:09 +0100)]
Update cmd tools to use python3

This includes changing to requests for check_patches_in_archives.py,
like previously done for the internal APIs.

6 years agoRemove oneoff tool instead of having to port it
Magnus Hagander [Wed, 6 Feb 2019 19:03:12 +0000 (20:03 +0100)]
Remove oneoff tool instead of having to port it

6 years agoFix class property reference for py3
Magnus Hagander [Wed, 6 Feb 2019 18:58:48 +0000 (19:58 +0100)]
Fix class property reference for py3

6 years agoUnicode fixes for python 3
Magnus Hagander [Wed, 6 Feb 2019 18:42:47 +0000 (19:42 +0100)]
Unicode fixes for python 3

6 years agoImport latest, py3 compatible, auth.py
Magnus Hagander [Wed, 6 Feb 2019 19:01:20 +0000 (20:01 +0100)]
Import latest, py3 compatible, auth.py

6 years agoFix imports and exceptions for Python3
Magnus Hagander [Wed, 6 Feb 2019 18:40:45 +0000 (19:40 +0100)]
Fix imports and exceptions for Python3

6 years agoFixes for pep8 compatibility
Magnus Hagander [Tue, 5 Feb 2019 22:55:23 +0000 (23:55 +0100)]
Fixes for pep8 compatibility

6 years agoConvert all spaces to tabs
Magnus Hagander [Tue, 5 Feb 2019 22:01:05 +0000 (23:01 +0100)]
Convert all spaces to tabs

6 years agoSwitch to using requests for archives API
Magnus Hagander [Tue, 5 Feb 2019 21:56:05 +0000 (22:56 +0100)]
Switch to using requests for archives API

This should fix some unicode issues

6 years agoChange sort order for reviewers/authors in filter dropdown
Magnus Hagander [Wed, 26 Dec 2018 11:52:01 +0000 (12:52 +0100)]
Change sort order for reviewers/authors in filter dropdown

Previously it was sorted by last name, which did not always make sense.
Canged to sort by first name, which hopefully makes more sense.

Per request from Alvaro Herrera and others.

6 years agoAdd "withdrawn" commitfest status
Magnus Hagander [Sun, 23 Dec 2018 12:07:56 +0000 (13:07 +0100)]
Add "withdrawn" commitfest status

By popular (?) request

6 years agoMerge old model changes that never made it into migrations
Magnus Hagander [Sun, 23 Dec 2018 12:00:07 +0000 (13:00 +0100)]
Merge old model changes that never made it into migrations

6 years agoClarify some buttons
Andreas Scherbaum [Mon, 26 Nov 2018 12:46:57 +0000 (13:46 +0100)]
Clarify some buttons

Add some longer texts to indicate what's really hiding behind buttons.

6 years agoDon't use hardcoded pgsql-hackers name in status message
Andreas Scherbaum [Fri, 16 Nov 2018 13:20:03 +0000 (14:20 +0100)]
Don't use hardcoded pgsql-hackers name in status message

Instead use the value from the settings file, which is what's actually
used to send.

6 years agoInclude DKIM/SPF instructions on commit/review forms
Andreas Scherbaum [Fri, 16 Nov 2018 13:16:12 +0000 (14:16 +0100)]
Include DKIM/SPF instructions on commit/review forms

6 years agoClarify what subscribe/unsubscribe button does
Magnus Hagander [Sun, 4 Nov 2018 21:22:53 +0000 (22:22 +0100)]
Clarify what subscribe/unsubscribe button does

6 years agoAlso don't fail on invalid reviewers or authors
Magnus Hagander [Mon, 29 Oct 2018 11:48:35 +0000 (12:48 +0100)]
Also don't fail on invalid reviewers or authors

Same fix as the previous one for status, but applies to the other two
filter-by-dropdown fields.

6 years agoDon't fail on incorrect statuses in URL
Magnus Hagander [Sun, 16 Sep 2018 21:47:52 +0000 (23:47 +0200)]
Don't fail on incorrect statuses in URL

The comment said we should ignore the status if int() on it fails, but
to do that we have to fail it before we actually add the WHERE clause.
Thus, reorder the code to do so.

6 years agoFix colspan
Daniel Gustafsson [Mon, 18 Jun 2018 09:28:06 +0000 (11:28 +0200)]
Fix colspan

7 years agoBring back topic listing
Magnus Hagander [Tue, 29 May 2018 19:35:18 +0000 (15:35 -0400)]
Bring back topic listing

Accidentally broken when query was rewritten

7 years agoRewrite main CF dashboard query to use SQL
Magnus Hagander [Tue, 29 May 2018 19:28:35 +0000 (15:28 -0400)]
Rewrite main CF dashboard query to use SQL

We've long gone past what the django ORM can handle and got into
hundreds of queries for large commitfests. And it's not really that hard
to rewrite as SQL, even though we have to dynamically build the WHERE
clauses. So do that.

7 years agoShow the number of CFs a patch has been on
Magnus Hagander [Tue, 29 May 2018 18:25:12 +0000 (14:25 -0400)]
Show the number of CFs a patch has been on

Per discussions at the developer meeting, show the number of CFs a patch
has been on, and make it possible to sort on this value.

7 years agoDon't crash when passing in invalid values for filters
Magnus Hagander [Sun, 15 Apr 2018 12:49:13 +0000 (14:49 +0200)]
Don't crash when passing in invalid values for filters

Previously we'd throw a 500 internal server error, and cause error
logging to happen. This became evident when scripts trying to SQL-inject
the site started hitting us..

Instead, just ignore any filters that pass non-integer values into
integer fields completely.

7 years agoFix template loaders for django 1.11
Magnus Hagander [Sun, 25 Mar 2018 14:53:46 +0000 (16:53 +0200)]
Fix template loaders for django 1.11

Seems django 1.11 automatically enables caching template loader, which
of course breaks the ability to make any changes to the pages of a
website without restarting it. And there is no way to turn it off other
than to explicitly configure individual loders (the logic to turn it on
in non-debug configurations is hardcoded and cannot be changed).

7 years agoFix model diffing for django 1.11
Magnus Hagander [Thu, 22 Feb 2018 21:20:14 +0000 (22:20 +0100)]
Fix model diffing for django 1.11

7 years agoDon't allow null wikilink and gitlink
Magnus Hagander [Thu, 22 Feb 2018 21:19:46 +0000 (22:19 +0100)]
Don't allow null wikilink and gitlink

Both had a default set to '', so also put that in the model. Needed to
give correct diffs in newer djangos

7 years agoUpgrade django-selectable to v1.1.0
Magnus Hagander [Wed, 21 Feb 2018 21:05:18 +0000 (22:05 +0100)]
Upgrade django-selectable to v1.1.0

Needed for newer django

7 years agoFix warning triggered in django 1.11
Magnus Hagander [Wed, 21 Feb 2018 18:57:50 +0000 (19:57 +0100)]
Fix warning triggered in django 1.11

7 years agoImplement thread notification receiving
Magnus Hagander [Wed, 21 Feb 2018 17:31:54 +0000 (18:31 +0100)]
Implement thread notification receiving

This allows the archivs server to ping the CF app to pick up updates to
mailthreads quicker.

7 years agoUpdate format of urls.py to be compatible with newer django
Magnus Hagander [Wed, 21 Feb 2018 17:32:35 +0000 (18:32 +0100)]
Update format of urls.py to be compatible with newer django

7 years agoReplace render_to_response with render
Magnus Hagander [Wed, 21 Feb 2018 17:27:49 +0000 (18:27 +0100)]
Replace render_to_response with render

This is rquired as part of the move to a newer Django, and works fine on
older versions too

7 years agoFix template comparison operators
Magnus Hagander [Wed, 21 Feb 2018 17:34:02 +0000 (18:34 +0100)]
Fix template comparison operators

7 years agoUpdate template configuration syntax
Magnus Hagander [Wed, 21 Feb 2018 17:33:45 +0000 (18:33 +0100)]
Update template configuration syntax

Change to syntax compatible with newer Django, still works on current
version.

7 years agoActually deliver CCed emails to patch authors
Magnus Hagander [Sat, 20 Jan 2018 13:19:35 +0000 (14:19 +0100)]
Actually deliver CCed emails to patch authors

Previously we would set the Cc header of the email, but not actually
send a copy to the user. That way if the user was not subscribed to the
hackers email, they'd end up not receiving the email at all, which
somewhat defeats one of the original points of adding the Cc in the
first place.

Spotted by Peter Geoghegan

7 years agoUpdate README file
Pierre Giraud [Wed, 22 Nov 2017 19:08:31 +0000 (20:08 +0100)]
Update README file

While at it, convert to Markdown format for nicer rendering.

7 years agoFix typo
Daniel Gustafsson [Mon, 2 Oct 2017 08:02:44 +0000 (10:02 +0200)]
Fix typo

7 years agoHide annotation button if user is not logged in
Daniel Gustafsson [Mon, 18 Sep 2017 19:27:51 +0000 (21:27 +0200)]
Hide annotation button if user is not logged in

Reported by Peter Geoghegan

7 years agoFix typo
Daniel Gustafsson [Tue, 5 Sep 2017 23:19:39 +0000 (16:19 -0700)]
Fix typo

7 years agoFix closing of <table> tag
Daniel Gustafsson [Mon, 4 Sep 2017 10:38:24 +0000 (12:38 +0200)]
Fix closing of <table> tag

7 years agoFix incorrect reference to global templates directory
Magnus Hagander [Mon, 28 Aug 2017 10:59:30 +0000 (12:59 +0200)]
Fix incorrect reference to global templates directory

This has probably been needed since an upgrade a long time ago but got
stuck in a separate branch. Fixes the case where the admin interface
could end up rendering a login form that would then not work, instead of
providing the proper redirect.

7 years agoRemove deprecated and superfluous <script> attributes
Daniel Gustafsson [Tue, 27 Jun 2017 20:19:17 +0000 (22:19 +0200)]
Remove deprecated and superfluous <script> attributes

The language attribute has been deprecated for quite some time with
the type attribute setting the type of embedded content.  The type
attribute has further been defined to text/javascript as the default
value in the spec, so no attribute should be used for Javascript.
Per the standard: https://www.w3.org/TR/html5/scripting-1.html

7 years agoFix broken markup in future commitfests
Daniel Gustafsson [Tue, 27 Jun 2017 20:16:49 +0000 (22:16 +0200)]
Fix broken markup in future commitfests

7 years agoFix incorrect markup
Daniel Gustafsson [Tue, 20 Jun 2017 06:52:13 +0000 (08:52 +0200)]
Fix incorrect markup

7 years agoProperly close <form> tag.
Daniel Gustafsson [Tue, 20 Jun 2017 06:50:23 +0000 (08:50 +0200)]
Properly close <form> tag.

8 years agoFix header encoding for To and Cc as well
Magnus Hagander [Sat, 11 Mar 2017 18:33:08 +0000 (13:33 -0500)]
Fix header encoding for To and Cc as well

Patch in 2e41b31654b80aeb3e6037fc0b31422c951040c7 only handled From and
missed the ohher tields. To make this cleaner, move the escpaping code
into the UserWrapper class.

Reported by Dagfinn Ilmari Mannsåker, but not using his patch

8 years agoMake http links to the main website be https
Magnus Hagander [Thu, 9 Mar 2017 21:15:26 +0000 (16:15 -0500)]
Make http links to the main website be https

8 years agoProperly handle UTF8 in sender names in emails
Magnus Hagander [Tue, 28 Feb 2017 12:43:08 +0000 (13:43 +0100)]
Properly handle UTF8 in sender names in emails

We need to treat them as structured and escape only the name, not the
email part.

Reported by Dagfinn Ilmari Mannsåker

8 years agoFix incorrect parameter name
Magnus Hagander [Mon, 16 Jan 2017 09:20:20 +0000 (10:20 +0100)]
Fix incorrect parameter name

This changed back when we upgraded django, but this error path is
clearly very seldomly hit.

8 years agoFully qualify parameters to HTTPConnection/HTTPSConnection
Magnus Hagander [Sat, 7 Jan 2017 13:19:01 +0000 (14:19 +0100)]
Fully qualify parameters to HTTPConnection/HTTPSConnection

They go in different orders in the two, so fully specify them to make it
super clear.

8 years agoAttempt to support https in calls to archives
Magnus Hagander [Sat, 7 Jan 2017 13:09:23 +0000 (14:09 +0100)]
Attempt to support https in calls to archives

8 years agoAdd a README describing basic setup etc.
Peter van Hardenberg [Fri, 16 Dec 2016 09:20:56 +0000 (09:20 +0000)]
Add a README describing basic setup etc.

8 years agoFix django version in requirements.txt
Magnus Hagander [Fri, 2 Dec 2016 08:00:21 +0000 (17:00 +0900)]
Fix django version in requirements.txt

9 years agoCC authors of patches on comments and reviews
Magnus Hagander [Wed, 6 Apr 2016 15:45:27 +0000 (17:45 +0200)]
CC authors of patches on comments and reviews

This adds the Cc field when using the Review or the Comment function on
the website, and will add a list of all listed authors of the patch to
this. Should help people highlight it in their inboxes.

Suggested by José Luis Tallón

9 years agoAnd from the main editing form. Oops.
Magnus Hagander [Thu, 10 Mar 2016 13:23:28 +0000 (14:23 +0100)]
And from the main editing form. Oops.

9 years agoSubscribers should be excluded from new patches form
Magnus Hagander [Thu, 10 Mar 2016 13:22:19 +0000 (14:22 +0100)]
Subscribers should be excluded from new patches form

9 years agoMaintain patch status when moving to next CF
Magnus Hagander [Wed, 2 Mar 2016 13:39:17 +0000 (14:39 +0100)]
Maintain patch status when moving to next CF

So a patch that's in "ready for committer" status remains there.

When doing this, also refuse to move any patches that are not either
"waiting for review" or "ready for committer". They will have to have
their existing status changed first, and then be moved.

9 years agoDon't crash on subscribers without a profile
Magnus Hagander [Sat, 27 Feb 2016 14:21:02 +0000 (09:21 -0500)]
Don't crash on subscribers without a profile

9 years agoDon't crash with committers without user profiles
Magnus Hagander [Mon, 15 Feb 2016 09:38:31 +0000 (10:38 +0100)]
Don't crash with committers without user profiles

Userprofiles aren't set for everbody, so catch a missing exception and
just ignore it since we know a user without a profile didn't specifically
ask to get notified (as that's stored in the profile).

9 years agoAdd simple updating script
Magnus Hagander [Sat, 13 Feb 2016 11:59:16 +0000 (12:59 +0100)]
Add simple updating script

Intended to be run manually, but to make life easier at least.

9 years agoImplement notifications
Magnus Hagander [Fri, 12 Feb 2016 17:03:26 +0000 (18:03 +0100)]
Implement notifications

This makes it possible to receive notifications (via email) when a patch
has been updated.

It's possible to subscribe to notifications on a specific patch. It is also
possible to set the user profile up so that one receives notifications for
all patches where one is author, reviewer or committer on.

Notifications are, of course, only sent when other people make modifications
to the entry.

9 years agoAdmin view for user profiles
Magnus Hagander [Fri, 12 Feb 2016 15:58:45 +0000 (16:58 +0100)]
Admin view for user profiles

9 years agoAdd initial django migrations for all apps
Magnus Hagander [Fri, 12 Feb 2016 14:44:05 +0000 (15:44 +0100)]
Add initial django migrations for all apps

Should've been done with the migration to django 1.8, but better late
than never...

9 years agoShow if a committer is active in the admin view
Magnus Hagander [Fri, 12 Feb 2016 14:41:50 +0000 (15:41 +0100)]
Show if a committer is active in the admin view

9 years agoUse OneToOne field instead of unique foreign key
Magnus Hagander [Fri, 12 Feb 2016 14:40:39 +0000 (15:40 +0100)]
Use OneToOne field instead of unique foreign key

Newer djangos give warnings about this...

9 years agoAdd button for New Patch to top of page
Magnus Hagander [Tue, 9 Feb 2016 12:59:50 +0000 (13:59 +0100)]
Add button for New Patch to top of page

Per request during Brussels developer meeting

9 years agoLink status entries to the patch in the individual commitfest
Magnus Hagander [Tue, 2 Feb 2016 15:45:27 +0000 (16:45 +0100)]
Link status entries to the patch in the individual commitfest

As requested by Jim Nasby and Alvaro Herrera

9 years agoProperly show login info on report page
Magnus Hagander [Wed, 20 Jan 2016 21:26:47 +0000 (22:26 +0100)]
Properly show login info on report page

9 years agoAdd report showing author/reviewer stats
Magnus Hagander [Wed, 20 Jan 2016 21:23:15 +0000 (22:23 +0100)]
Add report showing author/reviewer stats

Grouped by each contriubtor, show which patches this person is the
author and reviewer of, to compare how many of each people have.

9 years agoFully qualify more imports
Magnus Hagander [Wed, 6 Jan 2016 16:35:31 +0000 (17:35 +0100)]
Fully qualify more imports

9 years agoNew way for django standalone scripts
Magnus Hagander [Wed, 6 Jan 2016 16:35:23 +0000 (17:35 +0100)]
New way for django standalone scripts

9 years agoAdd a symlink that seems to now be required
Magnus Hagander [Wed, 6 Jan 2016 16:17:23 +0000 (17:17 +0100)]
Add a symlink that seems to now be required

9 years agoProperly require login for lookup
Magnus Hagander [Wed, 6 Jan 2016 15:35:50 +0000 (16:35 +0100)]
Properly require login for lookup

9 years agoReplace on_success_commit with atomic
Magnus Hagander [Wed, 6 Jan 2016 15:34:50 +0000 (16:34 +0100)]
Replace on_success_commit with atomic

9 years agoFix default url import namespace
Magnus Hagander [Wed, 6 Jan 2016 15:34:31 +0000 (16:34 +0100)]
Fix default url import namespace

9 years agoUpdate default settings as required in 1.8
Magnus Hagander [Wed, 6 Jan 2016 15:34:21 +0000 (16:34 +0100)]
Update default settings as required in 1.8

9 years agoFix import that has always been correct
Magnus Hagander [Wed, 6 Jan 2016 15:33:45 +0000 (16:33 +0100)]
Fix import that has always been correct

Somehow this worked on 1.4, probably by accident

9 years agoFully qualify imports
Magnus Hagander [Wed, 6 Jan 2016 15:33:27 +0000 (16:33 +0100)]
Fully qualify imports

9 years agoSwitch simplejson to json
Magnus Hagander [Wed, 6 Jan 2016 15:31:49 +0000 (16:31 +0100)]
Switch simplejson to json

Avoids one import...
T#

9 years agoMove around manage.py and create wsgi.py for django 1.8
Magnus Hagander [Wed, 6 Jan 2016 15:28:25 +0000 (16:28 +0100)]
Move around manage.py and create wsgi.py for django 1.8

9 years agoImport a new version of django-selectable
Magnus Hagander [Wed, 6 Jan 2016 15:27:59 +0000 (16:27 +0100)]
Import a new version of django-selectable

Needed for django 1.8

9 years agoFix incorrect closing tag
Magnus Hagander [Sun, 3 Jan 2016 10:04:14 +0000 (11:04 +0100)]
Fix incorrect closing tag

Noted by Erik Rijkers

9 years agoFix colspan in patches table lists
Oleksandr Shulgin [Mon, 28 Dec 2015 11:20:13 +0000 (12:20 +0100)]
Fix colspan in patches table lists

Account for the Committer column added in 8495806.

9 years agoPut the correct color on labels in patch viewing
Magnus Hagander [Sat, 3 Oct 2015 16:40:22 +0000 (18:40 +0200)]
Put the correct color on labels in patch viewing

Pointed out by Andres that the original patch only did the CF
listing, and not the actual patch viewing.

9 years agoShow the start and end date of commitfests
Magnus Hagander [Wed, 2 Sep 2015 11:19:48 +0000 (13:19 +0200)]
Show the start and end date of commitfests

Per request

9 years agoDon't crash on redirect when multiple CFs are inprogress or open
Magnus Hagander [Mon, 31 Aug 2015 14:44:57 +0000 (16:44 +0200)]
Don't crash on redirect when multiple CFs are inprogress or open

This is an incorrect state, but we shouldn't crash anyway. Instead show
an error message and redirect to the root page.

Reported by Bruce Momjian

9 years agoDon't raise exceptions for "normal errors"
Magnus Hagander [Thu, 27 Aug 2015 07:53:38 +0000 (09:53 +0200)]
Don't raise exceptions for "normal errors"

Exceptions will not show the actual error message on the site, only
send an email to the admins with it. Thus, anything that can normally
happen due to a user error should not use that. Instead of that, use
the messages framework so it renders on the next page.

9 years agoRemove accidental debugging code
Magnus Hagander [Fri, 14 Aug 2015 10:34:51 +0000 (12:34 +0200)]
Remove accidental debugging code