REASSIGN OWNED: consider grants on tablespaces, too

Apparently this was considered in the original code (see commit
cec3b0a9) but I failed to notice that such entries would always be
skipped by the database check at the start of the loop.

Per bugs #7578 by Nikolay, #6116 by tushar.qa@gmail.com.

diff --git a/src/backend/catalog/pg_shdepend.c b/src/backend/catalog/pg_shdepend.c
index 5a73b48ea766781395f5f4de56fcfee7172166c3..556371753566d6bd6b01d4ca920fa6d7b2838d9c 100644 (file)
--- a/src/backend/catalog/pg_shdepend.c
+++ b/src/backend/catalog/pg_shdepend.c
@@ -1217,8 +1217,12 @@ shdepDropOwned(List *roleids, DropBehavior behavior)
                        Form_pg_shdepend sdepForm = (Form_pg_shdepend) GETSTRUCT(tuple);
                        ObjectAddress obj;
 
-                       /* We only operate on objects in the current database */
-                       if (sdepForm->dbid != MyDatabaseId)
+                       /*
+                        * We only operate on shared objects and objects in the current
+                        * database
+                        */
+                       if (sdepForm->dbid != MyDatabaseId &&
+                               sdepForm->dbid != InvalidOid)
                                continue;
 
                        switch (sdepForm->deptype)