Check that we have a working tar before trying to use it
authorAndrew Dunstan <andrew@dunslane.net>
Wed, 8 Dec 2021 15:21:35 +0000 (10:21 -0500)
committerAndrew Dunstan <andrew@dunslane.net>
Wed, 8 Dec 2021 15:24:07 +0000 (10:24 -0500)
Issue exposed by commit edc2332550 and the buildfarm.

Backpatch to release 14 where this usage started.

src/bin/pg_basebackup/t/010_pg_basebackup.pl

index 89f45b77a341c25d9243bbf939031dee2ed3f82b..a7ded0694470a5c0ad5a64fe9fb6425d87c2ff71 100644 (file)
@@ -268,7 +268,8 @@ SKIP:
 {
    my $tar = $ENV{TAR};
    skip "no tar program available", 1
-     if (!defined $tar || $tar eq '');
+     if (!defined $tar || $tar eq ''
+         || system_log($tar, '--version') != 0);
 
    my $node2 = PostgreSQL::Test::Cluster->new('replica');