Fix outdated comment; all running bgworkers are in BackendList
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 1 Aug 2024 20:23:47 +0000 (23:23 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 1 Aug 2024 20:23:47 +0000 (23:23 +0300)
Before commit 8a02b3d732, only bgworkers that connected to a database
had an entry in the Backendlist. Commit 8a02b3d732 changed that, but
forgot to update this comment.

Discussion: https://www.postgresql.org/message-id/835232c0-a5f7-4f20-b95b-5b56ba57d741@iki.fi

src/include/postmaster/bgworker_internals.h

index 9106a0ef3f08ed5e7da065e4061a7b2e1c688bf2..61ba54117a8ddc4450dc861e090cc5e88d6f213d 100644 (file)
 /*
  * List of background workers, private to postmaster.
  *
- * A worker that requests a database connection during registration will have
- * rw_backend set, and will be present in BackendList.  Note: do not rely on
- * rw_backend being non-NULL for shmem-connected workers!
+ * All workers that are currently running will have rw_backend set, and will
+ * be present in BackendList.
  */
 typedef struct RegisteredBgWorker
 {
    BackgroundWorker rw_worker; /* its registry entry */
-   struct bkend *rw_backend;   /* its BackendList entry, or NULL */
+   struct bkend *rw_backend;   /* its BackendList entry, or NULL if not
+                                * running */
    pid_t       rw_pid;         /* 0 if not running */
    int         rw_child_slot;
    TimestampTz rw_crashed_at;  /* if not 0, time it last crashed */