Unify open and close status under one button
authorMagnus Hagander <magnus@hagander.net>
Tue, 15 Jul 2014 09:09:08 +0000 (11:09 +0200)
committerMagnus Hagander <magnus@hagander.net>
Tue, 15 Jul 2014 09:09:08 +0000 (11:09 +0200)
Instead we use subheaders to show the difference between statuses
that keep the patch open, and statuses that close it.

pgcommitfest/commitfest/templates/patch_commands.inc

index aeb96e2568fab5b5914850960151b18d8b984520..c78a1c0c7c259f0c8c9f5f809b6a05cb6ac6a706 100644 (file)
 
 <div class="btn-group">
  <a class="btn btn-default dropdown-toggle" data-toggle="dropdown" href="#">Status <span class="caret"></span></a>
- <ul class="dropdown-menu">
-  <li><a href="status/review/">Needs review</a></li>
-  <li><a href="status/author/">Waiting on Author</a></li>
-  <li><a href="status/committer/">Ready for Committer</a></li>
- </ul>
-</div>
-
-<div class="btn-group">
- <a class="btn btn-default dropdown-toggle" data-toggle="dropdown" href="#">Close <span class="caret"></span></a>
- <ul class="dropdown-menu">
-  <li><a href="close/reject/" onclick="return verify_reject()">Rejected</a></li>
-  <li><a href="close/feedback/" onclick="return verify_returned()">Returned with feedback</a></li>
-  <li><a href="close/committed/" onclick="return verify_committed({{is_committer|yesno:"true,false"}}))">Committed</a></li>
+ <ul class="dropdown-menu" role="menu">
+  <li role="presentation" class="dropdown-header">Open statuses</li>
+  <li role="presentation"><a href="status/review/">Needs review</a></li>
+  <li role="presentation"><a href="status/author/">Waiting on Author</a></li>
+  <li role="presentation"><a href="status/committer/">Ready for Committer</a></li>
+  <li role="presentation" class="divider"></li>
+  <li role="presentation" class="dropdown-header">Closed statuses</li>
+  <li role="presentation"><a href="close/reject/" onclick="return verify_reject()">Rejected</a></li>
+  <li role="presentation"><a href="close/feedback/" onclick="return verify_returned()">Returned with feedback</a></li>
+  <li role="presentation"><a href="close/committed/" onclick="return verify_committed({{is_committer|yesno:"true,false"}}))">Committed</a></li>
  </ul>
 </div>