Remove two_phase variable from CreateReplicationSlotCmd struct.

Commit 19890a064e added the option to enable two_phase commits via
pg_create_logical_replication_slot but didn't extend the support of same
in replication protocol. However, by mistake, it added the two_phase
variable in CreateReplicationSlotCmd which is required only when we extend
the replication protocol.

Reported-by: Jeff Davis
Author: Ajin Cherian
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/64b9f783c6e125f18f88fbc0c0234e34e71d8639.camel@j-davis.com

diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
index e94069c366a36e430e236946994b4c2bc1705f09..109c723f4e1e7ac166b62c745382b90e0936e698 100644 (file)
--- a/src/backend/replication/walsender.c
+++ b/src/backend/replication/walsender.c
@@ -954,7 +954,7 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)
                 */
                ReplicationSlotCreate(cmd->slotname, true,
                                                          cmd->temporary ? RS_TEMPORARY : RS_EPHEMERAL,
-                                                         cmd->two_phase);
+                                                         false);
        }
 
        if (cmd->kind == REPLICATION_KIND_LOGICAL)

diff --git a/src/include/nodes/replnodes.h b/src/include/nodes/replnodes.h
index ebc43a0293deb2b25cc042fd4f5e428e82bb406b..faa3a251f26d51b7a0f06ad1217a7cbae64f4198 100644 (file)
--- a/src/include/nodes/replnodes.h
+++ b/src/include/nodes/replnodes.h
@@ -56,7 +56,6 @@ typedef struct CreateReplicationSlotCmd
        ReplicationKind kind;
        char       *plugin;
        bool            temporary;
-       bool            two_phase;
        List       *options;
 } CreateReplicationSlotCmd;