Suppress more compiler warnings in new pgstats code.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 1 Mar 2023 01:30:37 +0000 (20:30 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 1 Mar 2023 01:30:49 +0000 (20:30 -0500)
Per buildfarm, we didn't get rid of quite all of the
-Wtautological-constant-out-of-range-compare warnings
in pgstat_io.c.

Discussion: https://postgr.es/m/20520.1677435600@sss.pgh.pa.us

src/backend/utils/activity/pgstat_io.c

index c4199d18c8a43fd1230deade7bccebe177f21c44..af5d554610195fb38eb9f0f096ea45c1f1fec111 100644 (file)
@@ -65,9 +65,9 @@ pgstat_bktype_io_stats_valid(PgStat_BktypeIO *backend_io,
 void
 pgstat_count_io_op(IOObject io_object, IOContext io_context, IOOp io_op)
 {
-       Assert(io_object < IOOBJECT_NUM_TYPES);
-       Assert(io_context < IOCONTEXT_NUM_TYPES);
-       Assert(io_op < IOOP_NUM_TYPES);
+       Assert((unsigned int) io_object < IOOBJECT_NUM_TYPES);
+       Assert((unsigned int) io_context < IOCONTEXT_NUM_TYPES);
+       Assert((unsigned int) io_op < IOOP_NUM_TYPES);
        Assert(pgstat_tracks_io_op(MyBackendType, io_object, io_context, io_op));
 
        PendingIOStats.data[io_object][io_context][io_op]++;