Fix comments in ReplicationSlotAcquire().
authorAmit Kapila <akapila@postgresql.org>
Mon, 29 Jan 2024 04:42:58 +0000 (10:12 +0530)
committerAmit Kapila <akapila@postgresql.org>
Mon, 29 Jan 2024 04:42:58 +0000 (10:12 +0530)
They were incorrectly referring to a slot parameter in
ReplicationSlotAcquire() which is not passed to the API.

Author: Wang Wei
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/OS3PR01MB6275E3CE4DC15FF8B8B80D3A9E7A2@OS3PR01MB6275.jpnprd01.prod.outlook.com

src/backend/replication/slot.c

index f2781d0455ac9ce3f6c80dd9fe4209086e537158..110cb59783f039b0fde4ec6517759e48bd719511 100644 (file)
@@ -465,10 +465,7 @@ retry:
 
        LWLockAcquire(ReplicationSlotControlLock, LW_SHARED);
 
-       /*
-        * Search for the slot with the specified name if the slot to acquire is
-        * not given. If the slot is not found, we either return -1 or error out.
-        */
+       /* Check if the slot exits with the given name. */
        s = SearchNamedReplicationSlot(name, false);
        if (s == NULL || !s->in_use)
        {