Fix performance issue in exprTypmod(): for a COALESCE expression, it

recursed twice on its first argument, leading to exponential time spent
on a deep nest of COALESCEs ... such as a deeply nested FULL JOIN would
produce.  Per report from Matt Carter.

diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c
index ab9279abd30ec607970c4a9f827076d7f3c7da98..3a57e5b5147bcb985afe7f1630cb9affc5ff5e3c 100644 (file)
--- a/src/backend/parser/parse_expr.c
+++ b/src/backend/parser/parse_expr.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/parser/parse_expr.c,v 1.185 2005/10/15 02:49:22 momjian Exp $
+ *       $PostgreSQL: pgsql/src/backend/parser/parse_expr.c,v 1.186 2005/11/18 23:08:00 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1664,8 +1664,12 @@ exprTypmod(Node *expr)
                                int32           typmod;
                                ListCell   *arg;
 
+                               if (exprType((Node *) linitial(cexpr->args)) != coalescetype)
+                                       return -1;
                                typmod = exprTypmod((Node *) linitial(cexpr->args));
-                               foreach(arg, cexpr->args)
+                               if (typmod < 0)
+                                       return -1;      /* no point in trying harder */
+                               for_each_cell(arg, lnext(list_head(cexpr->args)))
                                {
                                        Node       *e = (Node *) lfirst(arg);
 
@@ -1688,8 +1692,12 @@ exprTypmod(Node *expr)
                                int32           typmod;
                                ListCell   *arg;
 
+                               if (exprType((Node *) linitial(mexpr->args)) != minmaxtype)
+                                       return -1;
                                typmod = exprTypmod((Node *) linitial(mexpr->args));
-                               foreach(arg, mexpr->args)
+                               if (typmod < 0)
+                                       return -1;      /* no point in trying harder */
+                               for_each_cell(arg, lnext(list_head(mexpr->args)))
                                {
                                        Node       *e = (Node *) lfirst(arg);