Remove dead code from _bt_update_posting().
authorPeter Geoghegan <pg@bowt.ie>
Sun, 1 Mar 2020 20:11:26 +0000 (12:11 -0800)
committerPeter Geoghegan <pg@bowt.ie>
Sun, 1 Mar 2020 20:11:26 +0000 (12:11 -0800)
Discussion: https://postgr.es/m/CAH2-WzmAufHiOku6AGiFD=81VQs5nYJ1L2YkhW1t+BH4CMsgRw@mail.gmail.com

src/backend/access/nbtree/nbtdedup.c

index e5481f2f93fe4466fd8d98bf53e837a5ab04d8ce..3175d6fdd1d83b08617336b5b9459d9edacf1418 100644 (file)
@@ -674,11 +674,6 @@ _bt_update_posting(BTVacuumPosting vacposting)
        Assert(_bt_posting_valid(origtuple));
        Assert(nhtids > 0 && nhtids < BTreeTupleGetNPosting(origtuple));
 
-       if (BTreeTupleIsPosting(origtuple))
-               keysize = BTreeTupleGetPostingOffset(origtuple);
-       else
-               keysize = IndexTupleSize(origtuple);
-
        /*
         * Determine final size of new tuple.
         *
@@ -686,6 +681,7 @@ _bt_update_posting(BTVacuumPosting vacposting)
         * for new posting list tuples.  We avoid calling _bt_form_posting() here
         * to save ourselves a second memory allocation for a htids workspace.
         */
+       keysize = BTreeTupleGetPostingOffset(origtuple);
        if (nhtids > 1)
                newsize = MAXALIGN(keysize +
                                                   nhtids * sizeof(ItemPointerData));