Use one, not zero, as the default lower bound for arrays of AclItems.

This avoids changing the displayed appearance of ACL columns now that
array_out decorates its output with bounds information when the lower
bound isn't one.  Per gripe from Gaetano Mendola.  Note that I did not
force initdb for this, although any database initdb'd in the last
couple of days is going to have some problems.

diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.c
index 290c3ed49d2d04335e0531b9706af0af0bda2ca7..4464579857a4984c74b2644d4d09309f137c65ef 100644 (file)
--- a/src/backend/utils/adt/acl.c
+++ b/src/backend/utils/adt/acl.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/adt/acl.c,v 1.108 2004/08/01 20:30:49 tgl Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/adt/acl.c,v 1.109 2004/08/06 18:05:48 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -328,7 +328,7 @@ allocacl(int n)
        new_acl->ndim = 1;
        new_acl->flags = 0;
        new_acl->elemtype = ACLITEMOID;
-       ARR_LBOUND(new_acl)[0] = 0;
+       ARR_LBOUND(new_acl)[0] = 1;
        ARR_DIMS(new_acl)[0] = n;
        return new_acl;
 }

diff --git a/src/include/utils/acl.h b/src/include/utils/acl.h
index cf13038ad004be74ee9f117ba2a6f5b768580b4e..7ed019c7a35e5f132b200351127d3a71093ff25f 100644 (file)
--- a/src/include/utils/acl.h
+++ b/src/include/utils/acl.h
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/include/utils/acl.h,v 1.72 2004/08/01 20:30:49 tgl Exp $
+ * $PostgreSQL: pgsql/src/include/utils/acl.h,v 1.73 2004/08/06 18:05:49 tgl Exp $
  *
  * NOTES
  *       An ACL array is simply an array of AclItems, representing the union
@@ -99,7 +99,7 @@ typedef struct AclItem
  * Definitions for convenient access to Acl (array of AclItem) and IdList
  * (array of AclId).  These are standard PostgreSQL arrays, but are restricted
  * to have one dimension.  We also ignore the lower bound when reading,
- * and set it to zero when writing.
+ * and set it to one when writing.
  *
  * CAUTION: as of PostgreSQL 7.1, these arrays are toastable (just like all
  * other array types). Therefore, be careful to detoast them with the