Fix stop condition for dumping GRANT commands
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 26 Apr 2023 12:24:13 +0000 (14:24 +0200)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 26 Apr 2023 12:24:13 +0000 (14:24 +0200)
Commit ce6b672e44 changed dumping GRANT commands to ensure that
grantors already have an ADMIN OPTION on the role for which it
is granting permissions. Looping over the grants per role has a
stop condition on dumping the grant statements, but accidentally
missed updating the variable for the conditional check.

Author: Andreas Scherbaum <ads@pgug.de>
Co-authored-by: Artur Zakirov <zaartur@gmail.com>
Discussion: https://postgr.es/m/de44299d-cd31-b41f-2c2a-161fa5e586a5@pgug.de

src/bin/pg_dump/pg_dumpall.c

index 71a1319865d98efb009ae2808e64b7da79fc496a..988a0cd4735de20c84d51cc140a879923f44274c 100644 (file)
@@ -1052,6 +1052,7 @@ dumpRoleMembership(PGconn *conn)
                                PQfinish(conn);
                                exit_nicely(1);
                        }
+                       prev_remaining = remaining;
 
                        /* Make one pass over the grants for this role. */
                        for (i = start; i < end; ++i)