Fix pg_basebackup so that it accepts 0 as a valid compression level.

The help message for pg_basebackup specifies that the numbers 0 through 9
are accepted as valid values of -Z option. But, previously -Z 0 was rejected
as an invalid compression level.

Per discussion, it's better to make pg_basebackup treat 0 as valid
compression level meaning no compression, like pg_dump.

Back-patch to all supported versions.

Reported-By: Jeff Janes
Reviewed-By: Amit Kapila
Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hVfM0B64b1_bPVKRqg@mail.gmail.com

diff --git a/doc/src/sgml/ref/pg_basebackup.sgml b/doc/src/sgml/ref/pg_basebackup.sgml
index 4d679d0a0593541f9241e3c5337f036f0dc324b2..03615da480c0514576e920d5280faafc52d732a3 100644 (file)
--- a/doc/src/sgml/ref/pg_basebackup.sgml
+++ b/doc/src/sgml/ref/pg_basebackup.sgml
@@ -364,7 +364,7 @@ PostgreSQL documentation
       <listitem>
        <para>
         Enables gzip compression of tar file output, and specifies the
-        compression level (1 through 9, 9 being best
+        compression level (0 through 9, 0 being no compression and 9 being best
         compression). Compression is only available when using the tar
         format.
        </para>

diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
index ec69682d20848c53f60a80ff22251bbc81a7b42c..ed41db8e6e6ccdb7b06e1020c7dcf1bf9808b13a 100644 (file)
--- a/src/bin/pg_basebackup/pg_basebackup.c
+++ b/src/bin/pg_basebackup/pg_basebackup.c
@@ -2073,7 +2073,7 @@ main(int argc, char **argv)
                                break;
                        case 'Z':
                                compresslevel = atoi(optarg);
-                               if (compresslevel <= 0 || compresslevel > 9)
+                               if (compresslevel < 0 || compresslevel > 9)
                                {
                                        fprintf(stderr, _("%s: invalid compression level \"%s\"\n"),
                                                        progname, optarg);