Ensure that STDERR is empty in connect_ok tests

Connections performed via connect_ok() in TAP tests should not write
anything to STDERR.

Author: Jacob Champion <pchampion@vmware.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/9D4FFB61-392B-4A2C-B7E4-911797B4AC14@yesql.se
Discussion: https://postgr.es/m/ec146256e31afa0542f9fa970ec258c5f1a5f98.camel@vmware.com

diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
index 41beadff9dd7fafc470e2ab3b5462dae907cb919..ed70eff374bc6bfe0d708bff762aba6398d270fd 100644 (file)
--- a/src/test/perl/PostgreSQL/Test/Cluster.pm
+++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
@@ -2214,8 +2214,11 @@ sub connect_ok
 
    if (defined($params{expected_stdout}))
    {
-       like($stdout, $params{expected_stdout}, "$test_name: matches");
+       like($stdout, $params{expected_stdout}, "$test_name: stdout matches");
    }
+
+   is($stderr, "", "$test_name: no stderr");
+
    if (@log_like or @log_unlike)
    {
        my $log_contents = PostgreSQL::Test::Utils::slurp_file($self->logfile, $log_location);