Disable debug_discard_caches in test_oat_hooks test.

The test output varies when debug_discard_caches is enabled,
because that causes extra executions of recomputeNamespacePath.
Maybe putting a hook in that was a bad idea, but as a stopgap,
just turn off debug_discard_caches in this test.

Per buildfarm (now that we have debug_discard_caches coverage
again).  Back-patch to v15 where this module was added.

Discussion: https://postgr.es/m/2267406.1668804934@sss.pgh.pa.us

diff --git a/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out b/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out
index b053bc75cc977d9d1c58823a147a188095294fa0..f80373aecc03351dd127e43c15bbfe1f7e0ad9c5 100644 (file)
--- a/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out
+++ b/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out
@@ -1,3 +1,7 @@
+-- This test script fails if debug_discard_caches is enabled, because cache
+-- flushes cause extra calls of the OAT hook in recomputeNamespacePath,
+-- resulting in more NOTICE messages than are in the expected output.
+SET debug_discard_caches = 0;
 -- Creating privileges on a placeholder GUC should create entries in the
 -- pg_parameter_acl catalog which conservatively grant no privileges to public.
 CREATE ROLE regress_role_joe;

diff --git a/src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql b/src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql
index d0cca8c44eb9bf5d2e79ba68a363f14148d1bd5e..6b1e5008497f8488f6ab84352e6b47ce03347167 100644 (file)
--- a/src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql
+++ b/src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql
@@ -1,3 +1,8 @@
+-- This test script fails if debug_discard_caches is enabled, because cache
+-- flushes cause extra calls of the OAT hook in recomputeNamespacePath,
+-- resulting in more NOTICE messages than are in the expected output.
+SET debug_discard_caches = 0;
+
 -- Creating privileges on a placeholder GUC should create entries in the
 -- pg_parameter_acl catalog which conservatively grant no privileges to public.
 CREATE ROLE regress_role_joe;