Proeperly use requests to format URL parameters
authorMagnus Hagander <magnus@hagander.net>
Fri, 28 Jun 2019 13:03:53 +0000 (15:03 +0200)
committerMagnus Hagander <magnus@hagander.net>
Fri, 28 Jun 2019 14:28:15 +0000 (16:28 +0200)
hamnadmin/hamnadmin/register/forms.py

index 63fb4954788a851afdaa57ba672340258fa59f61..1824b971d10efedc0593d60edb5e754b31ca79db 100644 (file)
@@ -7,7 +7,6 @@ from .models import Blog
 
 from hamnadmin.util.aggregate import FeedFetcher, ParserGotRedirect
 
-import urllib.request, urllib.parse, urllib.error
 import requests
 import requests_oauthlib
 
@@ -69,8 +68,9 @@ class BlogEditForm(forms.ModelForm):
                                                                                         settings.TWITTER_TOKEN,
                                                                                         settings.TWITTER_TOKENSECRET)
                try:
-                       r = tw.get('https://api.twitter.com/1.1/users/show.json?screen_name={0}'.format(urllib.quote_plus(u)),
-                       timeout=5)
+                       r = tw.get('https://api.twitter.com/1.1/users/show.json', params={
+                               'screen_name': u,
+                               }, timeout=5)
                        if r.status_code != 200:
                                raise forms.ValidationError("Could not find twitter user")
                        j = r.json()