Fix overflow in extract(epoch from interval) for intervals exceeding 68 years.

Seems to have been introduced in 8.1 by careless SECS_PER_DAY
search-and-replace.

diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c
index 8d2c9318d86dc342d1875708284bb5db97145e38..9f5eee5c07b1e3fdce9fe97406e714f835eb5d1f 100644 (file)
--- a/src/backend/utils/adt/timestamp.c
+++ b/src/backend/utils/adt/timestamp.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.181 2007/08/04 01:26:54 tgl Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.182 2007/09/16 15:56:20 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -4395,9 +4395,9 @@ interval_part(PG_FUNCTION_ARGS)
 #else
                result = interval->time;
 #endif
-               result += (DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);
+               result += ((double) DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);
                result += ((double) DAYS_PER_MONTH * SECS_PER_DAY) * (interval->month % MONTHS_PER_YEAR);
-               result += interval->day * SECS_PER_DAY;
+               result += ((double) SECS_PER_DAY) * interval->day;
        }
        else
        {