Message improvement
authorPeter Eisentraut <peter@eisentraut.org>
Wed, 7 Apr 2021 05:37:30 +0000 (07:37 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Wed, 7 Apr 2021 05:42:44 +0000 (07:42 +0200)
The previous wording contained a superfluous comma.  Adjust phrasing
for grammatical correctness and clarity.

contrib/test_decoding/expected/slot.out
src/backend/replication/logical/logicalfuncs.c
src/backend/replication/slotfuncs.c

index ea72bf9f1573c64e3a5be03aa6c0daf9cad6a40d..75b4b5cc62576d8a953e4b6a5ce1df3c5dcda1bf 100644 (file)
@@ -144,7 +144,7 @@ SELECT pg_replication_slot_advance('regression_slot3', '0/0'); -- invalid LSN
 ERROR:  invalid target WAL LSN
 SELECT pg_replication_slot_advance('regression_slot3', '0/1'); -- error
 ERROR:  replication slot "regression_slot3" cannot be advanced
-DETAIL:  This slot has never previously reserved WAL, or has been invalidated.
+DETAIL:  This slot has never previously reserved WAL, or it has been invalidated.
 SELECT pg_drop_replication_slot('regression_slot3');
  pg_drop_replication_slot 
 --------------------------
index f7e055874e30577318fd55306e7a320a1e709575..01d354829b93671c9dae9f87a65701af66660459 100644 (file)
@@ -250,7 +250,7 @@ pg_logical_slot_get_changes_guts(FunctionCallInfo fcinfo, bool confirm, bool bin
                    (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
                     errmsg("can no longer get changes from replication slot \"%s\"",
                            NameStr(*name)),
-                    errdetail("This slot has never previously reserved WAL, or has been invalidated.")));
+                    errdetail("This slot has never previously reserved WAL, or it has been invalidated.")));
 
        MemoryContextSwitchTo(oldcontext);
 
index 9817b4411366399a8eddfaecc9c8afa3e7a621f0..d9d36879ed78532a63fa59c0cc361c8140924680 100644 (file)
@@ -647,7 +647,7 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS)
                (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
                 errmsg("replication slot \"%s\" cannot be advanced",
                        NameStr(*slotname)),
-                errdetail("This slot has never previously reserved WAL, or has been invalidated.")));
+                errdetail("This slot has never previously reserved WAL, or it has been invalidated.")));
 
    /*
     * Check if the slot is not moving backwards.  Physical slots rely simply