Fix compiler warning in jsonpath_exec.c
authorAlexander Korotkov <akorotkov@postgresql.org>
Sun, 17 Mar 2019 07:10:21 +0000 (10:10 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Sun, 17 Mar 2019 07:12:06 +0000 (10:12 +0300)
Warning was observed in gcc 4.4.6, gcc 4.4.7 and probably others.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/25151.1552751426%40sss.pgh.pa.us

src/backend/utils/adt/jsonpath_exec.c

index 4fc441f11e7f14472e81587a8302fdb78ac4ef5c..c07225749e5620841f6345069d413cce641c320a 100644 (file)
@@ -1459,15 +1459,11 @@ executePredicate(JsonPathExecContext *cxt, JsonPathItem *pred,
                JsonbValue *rval;
                bool            first = true;
 
+               JsonValueListInitIterator(&rseq, &rseqit);
                if (rarg)
-               {
-                       JsonValueListInitIterator(&rseq, &rseqit);
                        rval = JsonValueListNext(&rseq, &rseqit);
-               }
                else
-               {
                        rval = NULL;
-               }
 
                /* Loop over right arg sequence or do single pass otherwise */
                while (rarg ? (rval != NULL) : first)