Rename ExecAggTransReparent, and improve its documentation.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 24 Apr 2023 17:01:33 +0000 (13:01 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 24 Apr 2023 17:01:33 +0000 (13:01 -0400)
commitfce3b26e97ca98de054734e2af7d9125661a9b3f
tree39507a1cc4b6aac89f6143b586fc5a2d032fd3fe
parent5a8366ad75eb70cffa791119b404c897983260c6
Rename ExecAggTransReparent, and improve its documentation.

The name of this function suggests that it ought to reparent R/W
expanded objects to be children of the persistent aggcontext, instead
of copying them.  In fact it does no such thing, and if you try to
make it do so you will see multiple regression failures.  Rename it
to the less-misleading ExecAggCopyTransValue, and add commentary
about why that attractive-sounding optimization won't work.  Also
adjust comments at call sites, some of which were describing logic
that has since been moved into ExecAggCopyTransValue.

Discussion: https://postgr.es/m/3004282.1681930251@sss.pgh.pa.us
src/backend/executor/execExprInterp.c
src/backend/executor/nodeAgg.c
src/backend/executor/nodeWindowAgg.c
src/backend/jit/llvm/llvmjit_expr.c
src/backend/jit/llvm/llvmjit_types.c
src/include/executor/execExpr.h