Correct comment and some documentation about REPLICA_IDENTITY_INDEX
authorMichael Paquier <michael@paquier.xyz>
Wed, 22 Dec 2021 07:37:58 +0000 (16:37 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 22 Dec 2021 07:37:58 +0000 (16:37 +0900)
commitfc95d35b9429096ec4d028d79dcf1fb8b5d4b16e
tree0da16795d28c6943eb8897e2f561ac490111598a
parent962951be3ce319052df014e0d23b6e7626df587f
Correct comment and some documentation about REPLICA_IDENTITY_INDEX

catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a
dropped index is equivalent to REPLICA_IDENTITY_DEFAULT.  The code tells
a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING.

The behavior exists since the introduction of replica identities, and
fe7fd4e even added tests for this case but I somewhat forgot to fix this
comment.

While on it, this commit reorganizes the documentation about replica
identities on the ALTER TABLE page, and a note is added about the case
of dropped indexes with REPLICA_IDENTITY_INDEX.

Author: Michael Paquier, Wei Wang
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com
Backpatch-through: 10
doc/src/sgml/ref/alter_table.sgml
src/include/catalog/pg_class.h