Make pg_basebackup ask the server to estimate the total backup size, by default.
authorFujii Masao <fujii@postgresql.org>
Thu, 19 Mar 2020 08:09:00 +0000 (17:09 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 19 Mar 2020 08:09:00 +0000 (17:09 +0900)
commitfab13dc50ba5e7a12b474a7366024681bc169ac8
tree209273b0ab152b4564e839ef22fd101969a43c1e
parentc314c147c0563c9758bdad988ffda8d64daa2db6
Make pg_basebackup ask the server to estimate the total backup size, by default.

This commit changes pg_basebackup so that it specifies PROGRESS option in
BASE_BACKUP replication command whether --progress is specified or not.
This causes the server to estimate the total backup size and report it in
pg_stat_progress_basebackup.backup_total, by default. This is reasonable
default because the time required for the estimation would not be so large
in most cases.

Also this commit adds new option --no-estimate-size to pg_basebackup.
This option prevents the server from the estimation, and so is useful to
avoid such estimation time if it's too long.

Author: Fujii Masao
Reviewed-by: Magnus Hagander, Amit Langote
Discussion: https://postgr.es/m/CABUevEyDPPSjP7KRvfTXPdqOdY5aWNkqsB5aAXs3bco5ZwtGHg@mail.gmail.com
doc/src/sgml/monitoring.sgml
doc/src/sgml/ref/pg_basebackup.sgml
src/bin/pg_basebackup/pg_basebackup.c