Fix ExecCheckPermissions call in RI_Initial_Check
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 4 May 2023 17:55:56 +0000 (19:55 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 4 May 2023 17:55:56 +0000 (19:55 +0200)
commitf75cec4fff877ef24e4932a628fc974f3116ed16
treeaa8a7e685d1da125319d4bad6a2264059386a45f
parent4c40995f61227c579bd7269a829c00013ac66492
Fix ExecCheckPermissions call in RI_Initial_Check

RI_Initial_Check was setting up a list of RTEPermissionInfo for
ExecCheckPermissions() wrong, and the problem is subtle enough that it
doesn't have any immediate effect in core code.  However, if an
extension is using the ExecutorCheckPerms_hook, then it would get the
wrong parameters and perhaps arrive at a wrong conclusion, or outright
malfunction.  Fix by constructing that list and the RTE list more
honestly.

We also add an assertion check to verify that these lists match.  This
new assertion would have caught this bug.

Co-authored-by: Олег Целебровский (Oleg Tselebrovskii) <o.tselebrovskiy@postgrespro.ru>
Co-authored-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Amit Langote <amitlangote09@gmail.com>
Discussion: https://postgr.es/m/3722b7a2cbe27a1796ee40824bd86dd1@postgrespro.ru
src/backend/executor/execMain.c
src/backend/utils/adt/ri_triggers.c