pg_controldata: Fix possible errors on corrupted pg_control
authorAlexander Korotkov <akorotkov@postgresql.org>
Tue, 4 Feb 2025 22:15:17 +0000 (00:15 +0200)
committerAlexander Korotkov <akorotkov@postgresql.org>
Tue, 4 Feb 2025 22:45:16 +0000 (00:45 +0200)
commitf2205448b15e991478e8ba717732fc02b5a55d09
tree83488250fabe80a7306c2ceaea236ca8cb29e118
parenteeaf6891be48ac2940361717525c277a02c97e63
pg_controldata: Fix possible errors on corrupted pg_control

Protect against malformed timestamps.  Also protect against negative WalSegSz
as it triggers division by zero:

((0x100000000UL) / (WalSegSz)) can turn into zero in

XLogFileName(xlogfilename, ControlFile->checkPointCopy.ThisTimeLineID,
             segno, WalSegSz);

because if WalSegSz is -1 then by arithmetic rules in C we get
0x100000000UL / 0xFFFFFFFFFFFFFFFFUL == 0.

Author: Ilyasov Ian <ianilyasov@outlook.com>
Author: Anton Voloshin <a.voloshin@postgrespro.ru>
Backpatch-through: 13
src/bin/pg_controldata/pg_controldata.c