SQL/JSON: Fix JSON_TABLE() column deparsing
authorAmit Langote <amitlan@postgresql.org>
Fri, 6 Sep 2024 04:25:02 +0000 (13:25 +0900)
committerAmit Langote <amitlan@postgresql.org>
Fri, 6 Sep 2024 04:25:47 +0000 (13:25 +0900)
commitee75a03f37fc27c7f07a21dc22edf4511e31a4a1
tree046634b09276e3096c679cab1027cd44f13e9cb7
parent4d7e24e0f4d05b546228488ccdc2848a80245ffb
SQL/JSON: Fix JSON_TABLE() column deparsing

The deparsing code in get_json_expr_options() unnecessarily emitted
the default column-specific ON ERROR / EMPTY behavior when the
top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that
by not overriding the column-specific default, determined based on
the column's JsonExprOp in get_json_table_columns(), with
JSON_BEHAVIOR_ERROR when that is the top-level ON ERROR behavior.

Note that this only removes redundancy; the current deparsing output
is not incorrect, just redundant.

Reviewed-by: Jian He <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com
Backpatch-through: 17
src/backend/utils/adt/ruleutils.c
src/test/regress/expected/sqljson_jsontable.out
src/test/regress/sql/sqljson_jsontable.sql