Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.
authorAmit Kapila <akapila@postgresql.org>
Mon, 14 Nov 2022 05:13:33 +0000 (10:43 +0530)
committerAmit Kapila <akapila@postgresql.org>
Mon, 14 Nov 2022 05:13:33 +0000 (10:43 +0530)
commite848be60b5cf9a883765ea8e98c411e7fef0c1c6
tree34f07f9350093afd8df02a7b9461b175d243c4f1
parentad6c52846f13e4e86daa247c1369ed85558830e7
Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.

During XLOG_HASH_SPLIT_ALLOCATE_PAGE replay, we were checking for a
cleanup lock on the new bucket page after acquiring an exclusive lock on
it and raising a PANIC error on failure. However, it is quite possible
that checkpointer can acquire the pin on the same page before acquiring a
lock on it, and then the replay will lead to an error. So instead, directly
acquire the cleanup lock on the new bucket page during
XLOG_HASH_SPLIT_ALLOCATE_PAGE replay operation.

Reported-by: Andres Freund
Author: Robert Haas
Reviewed-By: Amit Kapila, Andres Freund, Vignesh C
Backpatch-through: 11
Discussion: https://postgr.es/m/20220810022617.fvjkjiauaykwrbse@awork3.anarazel.de
src/backend/access/hash/hash_xlog.c
src/backend/access/hash/hashpage.c