Refactor ListenSocket array.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 5 Oct 2023 12:05:25 +0000 (15:05 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 5 Oct 2023 12:05:25 +0000 (15:05 +0300)
commite29c46439511a2ba8b447079f2308384a4228c92
treef900a63203b214012f5881b14e1e0033507117dd
parent1c99cde2f3440c59f582d45b251412c9a9b54f62
Refactor ListenSocket array.

Keep track of the used size of the array. That avoids looping through
the whole array in a few places. It doesn't matter from a performance
point of view since the array is small anyway, but this feels less
surprising and is a little less code. Now that we have an explicit
NumListenSockets variable that is statically initialized to 0, we
don't need the loop to initialize the array.

Allocate the array in PostmasterContext. The array isn't needed in
child processes, so this allows reusing that memory. We could easily
make the array resizable now, but we haven't heard any complaints
about the current 64 sockets limit.

Discussion: https://www.postgresql.org/message-id/7bb7ad65-a018-2419-742f-fa5fd877d338@iki.fi
src/backend/libpq/pqcomm.c
src/backend/postmaster/postmaster.c
src/include/libpq/libpq.h