Get rid of old version of BuildTupleHashTable().
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 19 Dec 2024 23:07:00 +0000 (18:07 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 19 Dec 2024 23:07:00 +0000 (18:07 -0500)
commite0a2721f7c169b50617fed797d7336cd8f10bf77
treee0e3b0a910b11a86a23d929d7a6f892da5608bba
parentf0b900086a370e45f730138d55da4f260d24809c
Get rid of old version of BuildTupleHashTable().

It was reasonable to preserve the old API of BuildTupleHashTable()
in the back branches, but in HEAD we should actively discourage use
of that version.  There are no remaining callers in core, so just
get rid of it.  Then rename BuildTupleHashTableExt() back to
BuildTupleHashTable().

While at it, fix up the miserably-poorly-maintained header comment
for BuildTupleHashTable[Ext].  It looks like more than one patch in
this area has had the opinion that updating comments is beneath them.

Discussion: https://postgr.es/m/538343.1734646986@sss.pgh.pa.us
src/backend/executor/execGrouping.c
src/backend/executor/nodeAgg.c
src/backend/executor/nodeRecursiveunion.c
src/backend/executor/nodeSetOp.c
src/backend/executor/nodeSubplan.c
src/include/executor/executor.h