Add comments on avoid reuse of parse-time snapshot
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 28 Feb 2020 16:13:54 +0000 (13:13 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 28 Feb 2020 16:25:26 +0000 (13:25 -0300)
commitdb989184cda7f4aa1ff764cca96142029e7e093b
treedb5304a6d2fda33a4f0ea55686a7d69cc3a75fcd
parent1933ae629e7b706c6c23673a381e778819db307d
Add comments on avoid reuse of parse-time snapshot

Apparently, reusing the parse-time query snapshot for later steps
(execution) is a frequently considered optimization ... but it doesn't
work, for reasons discovered in thread [1].  Adding some comments about
why it doesn't really work can relieve some future hackers from wasting
time reimplementing it again.

[1] https://postgr.es/m/flat/5075D8DF.6050500@fuzzy.cz

Author: Michail Nikolaev
Discussion: https://postgr.es/m/CANtu0ogp6cTvMJObXP8n=k+JtqxY1iT9UV5MbGCpjjPa5crCiw@mail.gmail.com
src/backend/tcop/postgres.c