pg_basebackup: Fix a couple of recently-introduced bugs.
authorRobert Haas <rhaas@postgresql.org>
Thu, 27 Jan 2022 14:46:17 +0000 (09:46 -0500)
committerRobert Haas <rhaas@postgresql.org>
Thu, 27 Jan 2022 16:05:48 +0000 (11:05 -0500)
commitdabf63bc9a5b71f61c2c8712c85d33fdc06efa8c
treeff7c38b2819f1c3ccf6529013bfa2a356cf699dc
parentacea505186e65dff33db69517d36a02c7b4f0283
pg_basebackup: Fix a couple of recently-introduced bugs.

The server expects the compression level to be between 1 and 9, but
Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value
to the server.

Because pg_basebackup's -R option is implemented on the client side,
it can't be used in combination with a backup target. Error out if
someone tries that, instead of silently ignoring the option.

Both issues were reported by Tushar Ahuja; patch by me.

Discussion: http://postgr.es/m/CA+TgmoaMwgdx8HxBjF8hmbohVvPL_0H5LqNrSq0uU+7BKp_Q2A@mail.gmail.com
src/bin/pg_basebackup/pg_basebackup.c