Add construct_array_builtin, deconstruct_array_builtin
authorPeter Eisentraut <peter@eisentraut.org>
Fri, 1 Jul 2022 08:51:45 +0000 (10:51 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 1 Jul 2022 09:23:15 +0000 (11:23 +0200)
commitd746021de18baf0f29eff0388204a0664f41eb8b
tree21074e7935e62cd054e702d79e5c1fe7c8544733
parent7c2d6f8d3400edab2b91de7765db9ec71235fac9
Add construct_array_builtin, deconstruct_array_builtin

There were many calls to construct_array() and deconstruct_array() for
built-in types, for example, when dealing with system catalog columns.
These all hardcoded the type attributes necessary to pass to these
functions.

To simplify this a bit, add construct_array_builtin(),
deconstruct_array_builtin() as wrappers that centralize this hardcoded
knowledge.  This simplifies many call sites and reduces the amount of
hardcoded stuff that is spread around.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/2914356f-9e5f-8c59-2995-5997fc48bcba%40enterprisedb.com
51 files changed:
contrib/hstore/hstore_gin.c
contrib/hstore/hstore_gist.c
contrib/hstore/hstore_io.c
contrib/hstore/hstore_op.c
contrib/pageinspect/btreefuncs.c
contrib/pageinspect/ginfuncs.c
contrib/pageinspect/gistfuncs.c
contrib/pageinspect/hashfuncs.c
contrib/pageinspect/heapfuncs.c
contrib/pg_trgm/trgm_op.c
contrib/pgcrypto/pgp-pgsql.c
src/backend/access/common/reloptions.c
src/backend/catalog/objectaddress.c
src/backend/catalog/pg_constraint.c
src/backend/catalog/pg_proc.c
src/backend/catalog/pg_subscription.c
src/backend/commands/analyze.c
src/backend/commands/event_trigger.c
src/backend/commands/extension.c
src/backend/commands/functioncmds.c
src/backend/commands/policy.c
src/backend/commands/prepare.c
src/backend/commands/statscmds.c
src/backend/commands/subscriptioncmds.c
src/backend/commands/typecmds.c
src/backend/executor/nodeTidscan.c
src/backend/parser/parse_type.c
src/backend/parser/parse_utilcmd.c
src/backend/replication/logical/logicalfuncs.c
src/backend/statistics/extended_stats.c
src/backend/tsearch/dict.c
src/backend/utils/adt/arrayfuncs.c
src/backend/utils/adt/arrayutils.c
src/backend/utils/adt/hbafuncs.c
src/backend/utils/adt/json.c
src/backend/utils/adt/jsonb.c
src/backend/utils/adt/jsonb_gin.c
src/backend/utils/adt/jsonb_op.c
src/backend/utils/adt/jsonfuncs.c
src/backend/utils/adt/lockfuncs.c
src/backend/utils/adt/name.c
src/backend/utils/adt/orderedsetaggs.c
src/backend/utils/adt/pg_upgrade_support.c
src/backend/utils/adt/ruleutils.c
src/backend/utils/adt/tsvector_op.c
src/backend/utils/adt/xml.c
src/backend/utils/cache/evtcache.c
src/backend/utils/fmgr/funcapi.c
src/backend/utils/misc/guc.c
src/include/utils/array.h
src/test/modules/test_rls_hooks/test_rls_hooks.c