Allow a partdesc-omitting-partitions to be cached
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 28 Apr 2021 19:44:35 +0000 (15:44 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 28 Apr 2021 19:44:35 +0000 (15:44 -0400)
commitd6b8d29419df0efad57f95c80b871745d1b55da6
tree04627e39b8fc7d19c55179eb4bdd898d7fc9aa29
parentc93f8f3b8d3bc780892e2bf11192fbdd136fddfe
Allow a partdesc-omitting-partitions to be cached

Makes partition descriptor acquisition faster during the transient
period in which a partition is in the process of being detached.

This also adds the restriction that only one partition can be in
pending-detach state for a partitioned table.

While at it, return find_inheritance_children() API to what it was
before 71f4c8c6f74b, and create a separate
find_inheritance_children_extended() that returns detailed info about
detached partitions.

(This incidentally fixes a bug in 8aba9322511 whereby a memory context
holding a transient partdesc is reparented to a NULL PortalContext,
leading to permanent leak of that memory.  The fix is to no longer rely
on reparenting contexts to PortalContext.   Reported by Amit Langote.)

Per gripe from Amit Langote
Discussion: https://postgr.es/m/CA+HiwqFgpP1LxJZOBYGt9rpvTjXXkg5qG2+Xch2Z1Q7KrqZR1A@mail.gmail.com
doc/src/sgml/ref/alter_table.sgml
src/backend/catalog/pg_inherits.c
src/backend/commands/tablecmds.c
src/backend/commands/trigger.c
src/backend/partitioning/partdesc.c
src/backend/utils/cache/relcache.c
src/include/catalog/pg_inherits.h
src/include/utils/rel.h
src/test/isolation/expected/detach-partition-concurrently-3.out
src/test/isolation/specs/detach-partition-concurrently-3.spec