Fix traversing to the deleted GIN page via downlink
authorAlexander Korotkov <akorotkov@postgresql.org>
Tue, 19 Nov 2019 20:08:14 +0000 (23:08 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Tue, 19 Nov 2019 21:04:22 +0000 (00:04 +0300)
commitd5ad7a09afd066dce423f282bb2b338f48614d32
treeb8268a359957b32e29042e1c09845f4c48255e0d
parente14641197a5690d92cc48446d0d40f1aec07bac7
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4
src/backend/access/gin/ginbtree.c
src/backend/access/gin/gindatapage.c
src/backend/access/gin/ginvacuum.c
src/backend/access/gin/ginxlog.c