Remove Tuplesortstate.copytup function
authorAlexander Korotkov <akorotkov@postgresql.org>
Wed, 27 Jul 2022 05:26:53 +0000 (08:26 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Wed, 27 Jul 2022 05:26:53 +0000 (08:26 +0300)
commitd47da3162b4d77c888c895dd36e4ef9cb92fcf19
tree56bbb180d5145c28687983efc9f8df507f2f8d5a
parentffd1b6bb6f8a2ffc929699772610c6925364dbb3
Remove Tuplesortstate.copytup function

It's currently unclear how do we split functionality between
Tuplesortstate.copytup() function and tuplesort_put*() functions.
For instance, copytup_index() and copytup_datum() return error while
tuplesort_putindextuplevalues() and tuplesort_putdatum() do their work.
This commit removes Tuplesortstate.copytup() altogether, putting the
corresponding code into tuplesort_put*().

Discussion: https://postgr.es/m/CAPpHfdvjix0Ahx-H3Jp1M2R%2B_74P-zKnGGygx4OWr%3DbUQ8BNdw%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Pavel Borisov, Maxim Orlov, Matthias van de Meent
Reviewed-by: Andres Freund, John Naylor
src/backend/utils/sort/tuplesort.c