Fix misbehavior of DROP OWNED BY with duplicate polroles entries.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 18 Jun 2021 22:00:09 +0000 (18:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 18 Jun 2021 22:00:09 +0000 (18:00 -0400)
commitd21fca084356946664bfce19d66d2df2bb873cbd
tree44656864e42464675d15eb19e64f41e40c0c278d
parent84bee9610965331d5110971d8de390a5bbe2effc
Fix misbehavior of DROP OWNED BY with duplicate polroles entries.

Ordinarily, a pg_policy.polroles array wouldn't list the same role
more than once; but CREATE POLICY does not prevent that.  If we
perform DROP OWNED BY on a role that is listed more than once,
RemoveRoleFromObjectPolicy either suffered an assertion failure
or encountered a tuple-updated-by-self error.  Rewrite it to cope
correctly with duplicate entries, and add a CommandCounterIncrement
call to prevent the other problem.

Per discussion, there's other cleanup that ought to happen here,
but this seems like the minimum essential fix.

Per bug #17062 from Alexander Lakhin.  It's been broken all along,
so back-patch to all supported branches.

Discussion: https://postgr.es/m/17062-11f471ae3199ca23@postgresql.org
src/backend/commands/policy.c
src/test/regress/expected/rowsecurity.out
src/test/regress/sql/rowsecurity.sql