Remove wal_sync_method=fsync_writethrough on Windows.
authorThomas Munro <tmunro@postgresql.org>
Thu, 13 Jul 2023 23:59:07 +0000 (11:59 +1200)
committerThomas Munro <tmunro@postgresql.org>
Fri, 14 Jul 2023 00:30:13 +0000 (12:30 +1200)
commitd0c28601efaa8b04f11a19506f3371bba8438acc
tree04f752fbb2ade2b6fc9f44d1c0c4d9978c98e01b
parentaea7fe33fb6a96133c47cf4b3af25a7c62f49c06
Remove wal_sync_method=fsync_writethrough on Windows.

The "fsync" level already flushes drive write caches on Windows (as does
"fdatasync"), so it only confuses matters to have an apparently higher
level that isn't actually different at all.

That leaves "fsync_writethrough" only for macOS, where it actually does
something different.

Reviewed-by: Magnus Hagander <magnus@hagander.net>
Discussion: https://postgr.es/m/CA%2BhUKGJ2CG2SouPv2mca2WCTOJxYumvBARRcKPraFMB6GSEMcA%40mail.gmail.com
doc/src/sgml/wal.sgml
src/backend/storage/file/fd.c
src/bin/pg_test_fsync/pg_test_fsync.c
src/include/port/win32_port.h