Revise pg_pwrite_zeros()
authorMichael Paquier <michael@paquier.xyz>
Mon, 6 Mar 2023 04:21:33 +0000 (13:21 +0900)
committerMichael Paquier <michael@paquier.xyz>
Mon, 6 Mar 2023 04:21:33 +0000 (13:21 +0900)
commitce340e530d1f76367379a8d230ad5f411e5f25d2
tree6a17abed06cbd66092ea530a4b2894fc8148a185
parent47c0accbe05b5774a8a30e42e56e8d6026c9a858
Revise pg_pwrite_zeros()

The following changes are made to pg_write_zeros(), the API able to
write series of zeros using vectored I/O:
- Add of an "offset" parameter, to write the size from this position
(the 'p' of "pwrite" seems to mean position, though POSIX does not
outline ythat directly), hence the name of the routine is incorrect if
it is not able to handle offsets.
- Avoid memset() of "zbuffer" on every call.
- Avoid initialization of the whole IOV array if not needed.
- Group the trailing write() call with the main write() call,
simplifying the function logic.

Author: Andres Freund
Reviewed-by: Michael Paquier, Bharath Rupireddy
Discussion: https://postgr.es/m/20230215005525.mrrlmqrxzjzhaipl@awork3.anarazel.de
src/backend/access/transam/xlog.c
src/bin/pg_basebackup/walmethods.c
src/common/file_utils.c
src/include/common/file_utils.h