projects / users / rhaas / postgres.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 73c61a5) | patch
pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.
authorAndres Freund <andres@anarazel.de>
Fri, 25 Feb 2022 18:30:05 +0000 (10:30 -0800)
committerAndres Freund <andres@anarazel.de>
Fri, 25 Feb 2022 18:30:05 +0000 (10:30 -0800)
commitcd83cb953606b94966981056e79dbb6c48751055
treead69b11e6a78f2d120cac0e5c4533c7b43a5869atree
parent73c61a50a1555007001d29844dcdb10b4f982a73commit | diff
pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa
src/bin/pg_waldump/pg_waldump.c diff | blob | blame | history
Robert Haas's development tree.