Reject substituting extension schemas or owners matching ["$'\].
authorNoah Misch <noah@leadboat.com>
Mon, 7 Aug 2023 13:05:56 +0000 (06:05 -0700)
committerNoah Misch <noah@leadboat.com>
Mon, 7 Aug 2023 13:05:56 +0000 (06:05 -0700)
commitcd5f2a357014d5ed8205191f8e1fb180f1439599
tree5594c02f39e3eee78c16521037d730e8239c6a21
parent2bdd7b262f7af28dec11684bd8998f7dc2acc793
Reject substituting extension schemas or owners matching ["$'\].

Substituting such values in extension scripts facilitated SQL injection
when @extowner@, @extschema@, or @extschema:...@ appeared inside a
quoting construct (dollar quoting, '', or "").  No bundled extension was
vulnerable.  Vulnerable uses do appear in a documentation example and in
non-bundled extensions.  Hence, the attack prerequisite was an
administrator having installed files of a vulnerable, trusted,
non-bundled extension.  Subject to that prerequisite, this enabled an
attacker having database-level CREATE privilege to execute arbitrary
code as the bootstrap superuser.  By blocking this attack in the core
server, there's no need to modify individual extensions.  Back-patch to
v11 (all supported versions).

Reported by Micah Gate, Valerie Woolard, Tim Carey-Smith, and Christoph
Berg.

Security: CVE-2023-39417
src/backend/commands/extension.c
src/test/modules/test_extensions/Makefile
src/test/modules/test_extensions/expected/test_extensions.out
src/test/modules/test_extensions/meson.build
src/test/modules/test_extensions/sql/test_extensions.sql
src/test/modules/test_extensions/test_ext_extschema--1.0.sql [new file with mode: 0644]
src/test/modules/test_extensions/test_ext_extschema.control [new file with mode: 0644]