Fix checksum calculation in the new sorting GiST build.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 21 Sep 2020 11:50:07 +0000 (14:50 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 21 Sep 2020 11:50:07 +0000 (14:50 +0300)
commitc47a240fe6db8293e2de1565233faee40afa64b6
tree943e1c31e29d83b1caaf8bd5d2bcce94a5650723
parentc2bb287025189d93c8df16b28f2a3d9d07d25655
Fix checksum calculation in the new sorting GiST build.

Since we're bypassing the buffer manager, we need to call
PageSetChecksumInplace() directly. As reported by Justin Pryzby.

In the passing, add RelationOpenSmgr() calls before all smgrwrite() and
smgrextend() calls. Tom added one before the first smgrextend() call in
commit c2bb287025, which seems to be enough, but let's play it safe and
do it before each one. That's how it's done in the similar code in
nbtsort.c, too.

Discussion: https://www.postgresql.org/message-id/20200920224446.GF30557@telsasoft.com
src/backend/access/gist/gistbuild.c