Fix another portability bug in recent pgbench commit.
authorThomas Munro <tmunro@postgresql.org>
Wed, 10 Mar 2021 09:22:12 +0000 (22:22 +1300)
committerThomas Munro <tmunro@postgresql.org>
Wed, 10 Mar 2021 10:20:41 +0000 (23:20 +1300)
commitc427de427ac411039d5efd5d0dcc8a4e0c6da68d
treed6b9911e20ad3efe572d5e18e5136b20acafb28a
parent68b34b2338f013cb025dea360b37a3b4fc930179
Fix another portability bug in recent pgbench commit.

Commit 547f04e7 produced errors on AIX/xlc while building plpython.  The
new code appears to be incompatible with the hack installed by commit
a11cf433.  Without access to an AIX system to check, my guess is that
_POSIX_C_SOURCE may be required for <time.h> to declare the things the
header needs to see, but plpython.h undefines it.

For now, to unbreak build farm animal hoverfly, just move the new
pg_time_usec_t support into pgbench.c.  Perhaps later we could figure
out what to rearrange to put it back into a header for wider use.

Discussion: https://postgr.es/m/CA%2BhUKG%2BP%2BjcD%3Dx9%2BagyTdWtjpOT64MYiGic%2Bcbu_TD8CV%3D6A3w%40mail.gmail.com
src/bin/pgbench/pgbench.c
src/include/portability/instr_time.h