Fix interaction between CREATE INDEX and "snapshot too old".
authorKevin Grittner <kgrittn@postgresql.org>
Fri, 10 Jun 2016 14:25:31 +0000 (09:25 -0500)
committerKevin Grittner <kgrittn@postgresql.org>
Fri, 10 Jun 2016 14:25:31 +0000 (09:25 -0500)
commitbf9a60ee3349a2f2dc5fe6d571a8d39cfc634371
tree972c7b8a2af543202ec8d2a03643bfac4849410f
parentcae1c788b9b43887e4a4fa51a11c3a8ffa334939
Fix interaction between CREATE INDEX and "snapshot too old".

Since indexes are created without valid LSNs, an index created
while a snapshot older than old_snapshot_threshold existed could
cause queries to return incorrect results when those old snapshots
were used, if any relevant rows had been subject to early pruning
before the index was built.  Prevent usage of a newly created index
until all such snapshots are released, for relations where this can
happen.

Questions about the interaction of "snapshot too old" with index
creation were initially raised by Andres Freund.

Reviewed by Robert Haas.
src/backend/catalog/index.c
src/backend/storage/buffer/bufmgr.c
src/backend/utils/time/snapmgr.c
src/include/utils/snapmgr.h