Preserve pg_attribute.attstattarget across REINDEX CONCURRENTLY
authorMichael Paquier <michael@paquier.xyz>
Wed, 10 Feb 2021 04:06:48 +0000 (13:06 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 10 Feb 2021 04:06:48 +0000 (13:06 +0900)
commitbd12080980297dbc8ae926a3bd5b2ef9cc47932b
tree24c9dc81a8baf864d3051a0aae9a0f713cc424da
parentcd142e032ebd50ec7974b3633269477c2c72f1cc
Preserve pg_attribute.attstattarget across REINDEX CONCURRENTLY

For an index, attstattarget can be updated using ALTER INDEX SET
STATISTICS.  This data was lost on the new index after REINDEX
CONCURRENTLY.

The update of this field is done when the old and new indexes are
swapped to make the fix back-patchable.  Another approach we could look
after in the long-term is to change index_create() to pass the wanted
values of attstattarget when creating the new relation, but, as this
would cause an ABI breakage this can be done only on HEAD.

Reported-by: Ronan Dunklau
Author: Michael Paquier
Reviewed-by: Ronan Dunklau, Tomas Vondra
Discussion: https://postgr.es/m/16628084.uLZWGnKmhe@laptop-ronand
Backpatch-through: 12
src/backend/catalog/index.c
src/backend/utils/cache/lsyscache.c
src/include/utils/lsyscache.h
src/test/regress/expected/create_index.out
src/test/regress/sql/create_index.sql