Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 18 Nov 2012 22:15:06 +0000 (17:15 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 18 Nov 2012 22:15:06 +0000 (17:15 -0500)
commitb6e3798f3aa2747db145f25e03a8d34f2e5ec8c8
treed0cd6b85e9106a4c9c3d02d9addd5ebf135449b6
parentd038966ddb918872700f9f21affbc84d6bc2c029
Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds.

The previous definitions of these GUC variables allowed them to range
up to INT_MAX, but in point of fact the underlying code would suffer
overflows or other errors with large values.  Reduce the maximum values
to something that won't misbehave.  There's no apparent value in working
harder than this, since very large delays aren't sensible for any of
these.  (Note: the risk with archive_timeout is that if we're late
checking the state, the timestamp difference it's being compared to
might overflow.  So we need some amount of slop; the choice of INT_MAX/2
is arbitrary.)

Per followup investigation of bug #7670.  Although this isn't a very
significant fix, might as well back-patch.
contrib/auth_delay/auth_delay.c
src/backend/utils/misc/guc.c