Unify drop-by-OID functions
authorPeter Eisentraut <peter@eisentraut.org>
Tue, 9 Jun 2020 07:10:14 +0000 (09:10 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Tue, 9 Jun 2020 07:39:46 +0000 (09:39 +0200)
commitb1d32d3e3230f00b5baba08f75b4f665c7d6dac6
tree9b0b6bba1aab417382105d09fc2800f346c7ce2b
parentb27c90bbe4a3d607f8fc6703c7183e56e4039acd
Unify drop-by-OID functions

There are a number of Remove${Something}ById() functions that are
essentially identical in structure and only different in which catalog
they are working on.  Refactor this to be one generic function.  The
information about which oid column, index, etc. to use was already
available in ObjectProperty for most catalogs, in a few cases it was
easily added.

Reviewed-by: Pavel Stehule <pavel.stehule@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/331d9661-1743-857f-1cbb-d5728bcd62cb%402ndquadrant.com
23 files changed:
src/backend/catalog/aclchk.c
src/backend/catalog/dependency.c
src/backend/catalog/objectaddress.c
src/backend/catalog/pg_collation.c
src/backend/catalog/pg_conversion.c
src/backend/commands/amcmds.c
src/backend/commands/event_trigger.c
src/backend/commands/foreigncmds.c
src/backend/commands/functioncmds.c
src/backend/commands/opclasscmds.c
src/backend/commands/proclang.c
src/backend/commands/publicationcmds.c
src/backend/commands/schemacmds.c
src/backend/commands/tsearchcmds.c
src/include/catalog/objectaddress.h
src/include/catalog/pg_collation.h
src/include/catalog/pg_conversion.h
src/include/commands/defrem.h
src/include/commands/event_trigger.h
src/include/commands/proclang.h
src/include/commands/publicationcmds.h
src/include/commands/schemacmds.h
src/include/utils/acl.h